iree-org / iree-org/wave

Fix the semantics of Sympy `/` operator

Open
#337 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
59
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Currently we can see this kind of Sympy expressions (for index mapping or read/write bounds):
`$WG0*BLOCK_M + BLOCK_M*floor($T0/34)/2 + BLOCK_M/2`

So sometimes we use `floor` for division, sometimes it's just `/`. I'm not sure for expression such as `x/y`, `y` always divides `x`, i.e. in this case `BLOCK_M` is always even.

We thus need to decide for each `/` case whether it should be a `floordiv` or `ceildiv`, IMHO. @harsh-nod @ftynse @martin-luecke what do you think?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.