iree-org / iree-org/wave

`tkw.debug_log` should check that `register_` is `tkl.Register`

Open
#208 0 comments 0 reactions 1 assignee Assigned to @willghatch View on GitHub
enhancement
Dominant language
Python
Stars
59
Forks
32
PR merge metrics
No merged PRs in 30d

Description

If passed `register_=`, `tkw.debug_log` will eventually fail with an inscrutable error like

```
AssertionError: Vector shapes not set for node write: write(register_=kv_indices, memory=block_table, elements_per_thread=1, mapping_dynamic_vals=(), index={K2: 0 : 1 : 1}) type(Memory[K2].of(i32))
```

`tkw.debug_log` should probably check that `register_` is indeed `tkl.Register` and immediately fail with an informative error message if that's not the case.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.