iree-org / iree-org/iree

When --iree-llvmcpu-sanitize=address is enabled, we should auto set --iree-llvmcpu-link-embedded=false

Open
#15,519 12 comments 0 reactions 1 assignee Claimed by @harrisonGPU View on GitHub
good first issue 🌱
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
4d 16h
Merged PRs (30d)
47

Description

The test suite futzes with this at the CMake level but that still leaves the footgun in the compiler. Specifying the first flag causes an opaque link error about missing ASAN symbols with no clue as to how to fix it.

Recommend just making this work correctly when --iree-llvmcpu-sanitize=address is specified. Then also remove the checks and manual massaging done at the CMake level for the test suite to manage the --iree-llvmcpu-link-embedded flag.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.