iree-org / iree-org/iree

Compiler tool dynamic linking may not be setting CMake dependencies completely

Open
#11,331 6 comments 0 reactions 0 assignees View on GitHub
bug 🐞 compiler/tools infrastructure
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
4d 16h
Merged PRs (30d)
47

Description

Likely culprit: https://github.com/iree-org/iree/pull/11285

I'm noticing that when I make changes to compiler code and rebuild `iree-test-deps`, the `.vmfb` test files are not regenerated. I think we're missing a dependency link between `IREECompiler.dll` (.so on Linux) and `iree-compile.exe`. The `iree_check_test` targets depend on the compiler tool here: https://github.com/iree-org/iree/blob/45bd5504a791ba112a4eb52cd963d7915d302ac8/build_tools/cmake/iree_bytecode_module.cmake#L123-L140

Can anyone else confirm similar behavior? This might need more investigation.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported rebuild behavior with `iree-test-deps`, changing compiler code and checking whether the `.vmfb` test files regenerate. Read `build_tools/cmake/iree_bytecode_module.cmake` around the `iree_check_test` targets and compare their dependencies with `iree-compile.exe` and `IREECompiler.dll` (or `.so`). Done means the relevant CMake dependency relationship is complete and the regeneration behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.