__package__ = None
- Dominant language
- Jupyter Notebook
- Stars
- 258
- Forks
- 71
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I found that under certain circumstances `__package__` is not defined and hence FSFinder has no package_prefix set. This leads to an error when trying to import a notebook.
Can it be that this is because `__package__` is expected to be the same as __spec__.parent beginning with Python 3.6?
https://docs.python.org/3/reference/import.html#__package__
Anyway, relying on `__package__` seems to be a risk.
Best,
Jens Henrik
---------------------
```
...python3.6/site-packages/ipynb-0.5.1-py3.6.egg/ipynb/fs/finder.py in find_spec(self=, fullname='ipynb.fs.full.job_submit', path=['...site-packages/ipynb-0.5.1-py3.6.egg/ipynb/fs/full'], target=None)
41 Claims modules that are under ipynb.fs
42 """
---> 43 if fullname.startswith(self.package_prefix):
fullname.startswith =
self.package_prefix = None
44 for path in self._get_paths(fullname):
45 if os.path.exists(path):
TypeError: startswith first arg must be str or a tuple of str, not NoneType
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.