ipld / ipld/js-unixfs

Remove dependency on protobufjs

Open
#31 6 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11
Forks
6
PR merge metrics
No merged PRs in 30d

Description

From the [private thread discussing the issue](https://filecoinproject.slack.com/archives/C02BZPRS9HP/p1664366203595479)

> protobufjs is big, complex, uses eval and has circular dependencies
>
> ![image](https://user-images.githubusercontent.com/21236/193078119-12c69c01-f7db-41e5-864f-4bf7697865de.png)

Seem like there is even viable alternatives out there https://github.com/timostamm/protobuf-ts

Ideally we won't even pull in the peps here and go with approach @rvagg did in https://github.com/ipld/js-dag-pb/blob/master/src/pb-encode.js

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the current protobufjs dependency and the referenced js-dag-pb implementation at src/pb-encode.js, then compare the suggested protobuf-ts alternative. Done means protobufjs is no longer pulled in and UnixFS protobuf encoding continues to work with the chosen replacement.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.