ipld / ipld/js-ipld-schema

Properly handle non-nullable and non-optional scalar properties

Open
#83 0 comments 0 reactions 1 assignee Claimed by @rvagg View on GitHub
Dominant language
JavaScript
Stars
17
Forks
5
PR merge metrics
No merged PRs in 30d

Description

As per discussion in https://github.com/ipld/ipld/issues/268, if a struct has a map and/or list property that is not marked nullable or optional, we should expect the serialized form to have empty versions of these; I believe the current implementation will skip over them. Validation shouldn't pass if they are not present, and serialization should emit proper zero values of everything.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.