Do not announce non-dialable addresses
Open
kind/enhancement
- Dominant language
- Go
- Stars
- 17.1k
- Forks
- 3.2k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 11
Description
### Checklist
- [X] My issue is specific & actionable.
- [X] I am not suggesting a protocol enhancement.
- [X] I have searched on the [issue tracker](https://github.com/ipfs/kubo/issues?q=is%3Aissue) for my issue.
### Description
Right now, Kubo let's us put addresses in `Addresses.Announce` that we do not listen on and are, therefore, not dialable. It doesn't really make sense to be able to advertise addresses we do not listen on. This is a potential improvement. Right now I think it can also create some confusion, such as in #9823.
See https://github.com/ipfs/kubo/pull/9857#discussion_r1186080276
cc @aschmahmann
Contributor guide
Assessment
This issue has not been assessed yet.