ipfs / ipfs/kubo

feat: reduce RPC api surface area; remove subcommands that could be options/args

Open
#9,509 0 comments 0 reactions 0 assignees View on GitHub
kind/enhancement
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

### Checklist

- [X] My issue is specific & actionable.
- [X] I am not suggesting a protocol enhancement.
- [X] I have searched on the [issue tracker](https://github.com/ipfs/kubo/issues?q=is%3Aissue) for my issue.

### Description

in Kubo RPC client, there was a minor discussion in a PR to have the client API match the RPC endpoints, but that some of the endpoints should be removed and instead be passed as parameters (similar to CLI):

- https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-bitswap-wantlist should allow passing peer to wantlist
- https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-bootstrap-add-default should just be /add with a default flag.
- https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-bootstrap-rm-all should be /bootstrap/rm with an all option

See PR discussions:
* https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1050108696
* https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1048520906
* https://github.com/ipfs/js-kubo-rpc-client/pull/83#discussion_r1048523514

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.