ipfs / ipfs/kubo

CI should not publish Docker containers as latest if they are not the latest

Open
#8,863 0 comments 0 reactions 0 assignees View on GitHub
kind/bug need/triage
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

### Checklist

- [X] This is a bug report, not a question. Ask questions on [discuss.ipfs.io](https://discuss.ipfs.io).
- [X] I have searched on the [issue tracker](https://github.com/ipfs/go-ipfs/issues?q=is%3Aissue) for my bug.
- [X] I am running the latest [go-ipfs version](https://dist.ipfs.io/#go-ipfs) or have an issue updating.

### Installation method

built from source

### Version

_No response_

### Config

_No response_

### Description

When we push tags we publish Docker containers https://github.com/ipfs/go-ipfs/blob/d18f1f7ea90288309de593f352e96b085d1b5437/.github/workflows/docker-image.yml#L42.

However, we publish to the `latest` (and `release`) tags whenever there's a new versioned tag. https://github.com/ipfs/go-ipfs/blob/master/bin/get-docker-tags.sh#L44-L47

Unfortunately, this means that pushing patch release tag for an old version can overwrite a newer version. We should only update `latest` in a semver compatible way.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.