ipfs / ipfs/kubo

Make a QUIC optout tag to build without QUIC support

Open
#8,801 1 comment 0 reactions 0 assignees View on GitHub
kind/enhancement P3 status/deferred
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

### Checklist

- [X] My issue is specific & actionable.
- [X] I am not suggesting a protocol enhancement.
- [X] I have searched on the [issue tracker](https://github.com/ipfs/go-ipfs/issues?q=is%3Aissue) for my issue.

### Description

As some of you know the QUIC lib we use do some `unsafe` magic to edit private fields of structs in the crypto golang std libs.
That because the golang crypto libs are not exposing TLS details that you need to change if you do custom stuff.

To do that the quic lib (and transport by extension) are gated to specific golang versions because if the struct internally changed, the offsets or logic need to be manually updated.

I'm using the go1.19 branch from time to time and get tired to patch out the same 4 lines of code over and over.
If I could do:
```
go build -tags=noQUIC .
```
My life would be easier.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.