MFS remote pinning policy: log ERROR if pin failed
- Dominant language
- Go
- Stars
- 17.1k
- Forks
- 3.2k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 11
Description
go-ipfs 0.8.0-rc2 dispatches remote pin request but does not act on its status, so without manual inspection it is possible to miss the fact that MFS pinning (`Pinning.RemoteServices.*.Policies.MFS`, #7913) stopped working.
I believe we should keep checking pin status every `RepinInterval` until its `pinned` or `failed`, and if it's the latter, print ERROR into `remotepinning/mfs` logger. Pinning may fail for multiple reasons, main ones is some arbitrary timeout to find a provider for the data, another one is when you try to pin DAG bigger than allowed quota.
By printing error on MFS pin failure, node operator will be able to notice that remote pinning stopped working due to one of mentioned reasons.
cc #7559 @aschmahmann does this sound sensible?
Contributor guide
Assessment
This issue has not been assessed yet.