ipfs / ipfs/kubo

Bitswap sessions don't treat independent gets as independent

Open
#4,674 13 comments 0 reactions 0 assignees View on GitHub
kind/bug topic/bitswap
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

Scenario:

1. Construct a session.
2. Call Get in one thread for key K with ctxA
3. Call Get in another thread for key K with ctxB.

Canceling ctxA will cause the second Get to block forever.

We need to reference count interest.

(Note: By inspection, I haven't confirmed this)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.