ipfs / ipfs/kubo

Temporary pins when adding looks buggy

Open
#4,559 8 comments 0 reactions 0 assignees View on GitHub
exp/expert kind/bug
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

First, we don't appear to actually mark them as temporary. The following code appears dead in practice:

https://github.com/ipfs/go-ipfs/blob/1a0d6ec2ba1e114293cbb0a7d2394d7b48a554c2/core/coreunix/add.go#L198-L204

Second, this is *not* crash safe. We need a way to add in-memory pins.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.