ipfs / ipfs/kubo

Forbid non-cryptographic hashes within /ipfs namespace

Open
#4,371 23 comments 5 reactions 0 assignees View on GitHub
kind/bug need/community-input P3 topic/security
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

**Update:** This is DONE, we currently block non-cryptographic hash functions at blockstore level – see https://github.com/ipfs/go-ipfs/issues/4371#issuecomment-400031808

----

It just occured to me that by supporting non-cryptographic hashes (such as murmur3) in multihash, these are also available for CIDs, and can thus be used within the /ipfs namespace (example: ipfs/ipfs-companion#305).

This is not good! /ipfs paths MUST be cryptographically verifiable, it's their primary property. A lack of cryptographic verifiability seriously breaks so many assumptions on so many levels.

This would probably be appropriate to enforce within the respective IPLD modules.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.