ipfs / ipfs/kubo

Printing progress on add significantly slows down add

Open
#4,297 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

With #4296 applied, redirecting stdout to /dev/null speeds up add by ~17%. Something is waiting on this progress output that shouldn't be (we should be using a "lossy" channel to return progress updates, dropping any progress updates the client isn't ready for).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.