ipfs / ipfs/kubo

NoAnnounce should work for /dns addresses added by AutoTLS

Open
#10,830 1 comment 0 reactions 0 assignees View on GitHub
exp/intermediate help wanted kind/bug P2
Dominant language
Go
Stars
17.1k
Forks
3.2k
Avg merge
3d 18h
Merged PRs (30d)
11

Description

### Checklist

- [x] My issue is specific & actionable.
- [x] I am not suggesting a protocol enhancement.
- [x] I have searched on the [issue tracker](https://github.com/ipfs/kubo/issues?q=is%3Aissue) for my issue.

### Description

It seems that AutoTLS will figure out external IPs on ipv4 and ipv6 and add dns announce addresses accordingly. It does not take into account whether the IPs pointed to by these addresses are in the NoAnnounce filter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.