ipfs / ipfs/js-ipfs-utils

Defer to native-fetch whenever `ELECTRON_RUN_AS_NODE` is set

Open
#140 7 comments 1 reaction 0 assignees View on GitHub
need/triage
Dominant language
JavaScript
Stars
25
Forks
30
PR merge metrics
No merged PRs in 30d

Description

You guys are using `electron-fetch` whenever the `is-electron` package detects if it is running in an electron process (particularly, the main process). However, `is-electron` seems to be returning true even when in a process that has been forked from electron's main process as a node server.

This is currently what I am trying to set up in my own application, however, since you can't access electron from within a forked process, attempting to load `electron-fetch` results in an error wherein electron claims that it hasn't been installed properly.

The environment variable `ELECTRON_RUN_AS_NODE` is used to observe when a process is running as a fork from main, so I was thinking an additional condition could be added to defer to `native-fetch` whenever it is set.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.