Fix inconsistencies discovered in #261
- Dominant language
- TypeScript
- Stars
- 75
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
1. Should be `timeout` instead (as per comment here https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r589357353)
https://github.com/ipfs/js-ipfs-bitswap/blob/f546e4be772a0c76e21be0706195ce238e44be7e/src/network.js#L165-L167
2. equality check on messages seems to have a bug (for more context see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587863878)
https://github.com/ipfs/js-ipfs-bitswap/blob/f546e4be772a0c76e21be0706195ce238e44be7e/src/types/message/index.js#L207-L209
3. Want list entries sorting has a bug (See https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587867673)
4. Need to specify want type when adding it to wantlist (see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587865473)
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.