ipfs / ipfs/ipfs-webui

Set Pinning - Doesn't send the folder name

Open
#2,067 4 comments 0 reactions 0 assignees View on GitHub
effort/hours exp/beginner good first issue kind/bug P0 status/ready
Dominant language
JavaScript
Stars
1.6k
Forks
534
PR merge metrics
No merged PRs in 30d

Description

- OS: macOs
- Version of IPFS Desktop: 0.24.0

**Describe the bug**
When pinning a folder to a remote service through the Pinning Service API, the client sometimes does not send the `name` over.
The payload of the [POST request](https://ipfs.github.io/pinning-services-api-spec/#operation/addPin) sent contains the `cid` and `origins` but no `name`.

This has been raised by a user on a [web3.storage issue](https://github.com/orgs/web3-storage/projects/2/views/1?filterQuery=name).
To verify it wasn't a problem in [web3.storage](https://web3.storage/) implementation I tested this against a development instance of the service and logged `Add pin` payload to confirm no name is provided.

Unfortunately, this happens randomly, it sometimes does and sometimes doesn't, and I couldn't quite figure out a consistent way to reproduce it.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'settings'
2. Add web3.storage
3. Go to the file list
4. Click on the 3 dots on the right -> set pinning to the newly added service
5. Navigate to https://web3.storage/account/?table=pinned
6. See file appearing with "no name"

**Expected behavior**
It should send the name.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Please be aware that in order to be able to be able to pin on Web3.storage you need to have the PSA enabled, see [docs](url).
In order to see the [table](https://web3.storage/account/?table=pinned) you need to have at least a succesful pin.

Example of payload sent:
```
{
"cid": "QmeWZGxrwPyR532r4HTHUwWo6zJPZKxzPMnsm3Smbi2TDv",
"origins": [
"/ip4/192.168.1.3/tcp/4001/p2p/12D3KooWF59pZMi2q4qqqz6Mimi5oULWFQABYGXSQjNkR6sKC1kD",
.. more origins
]
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.