ipfs / ipfs/ipfs-desktop

Bug: Check for updates via menu-bar sub-menu action (macOS)

Open
#2,113 2 comments 0 reactions 0 assignees View on GitHub
area/macos effort/hours exp/intermediate help wanted kind/bug need/analysis P2 topic/macos
Dominant language
JavaScript
Stars
6.6k
Forks
903
Avg merge
4d 13h
Merged PRs (30d)
5

Description

- OS: macOS
- Version of IPFS Desktop [0.20.0]

**Describe the bug**
Using latest version of ipfs-desktop, manually selecting to check for updates locks up the UI when the desktop application is not open.

**To Reproduce**
Steps to reproduce the behavior(macos):
1. Start ipfs-desktop
2. Ensure the menu-bar application is visible, and then close the ipfs-desktop window (the application will still be running, and accessible via the menu-icon)
3. Click the ipfs-desktop menu-bar icon
4. Hover over about
5. Click on 'Check for updates'
* The sub-menu may close (I believe this is only on the newest version). If it does, re-open it before the update-checking is done in order to reproduce the bug.
7. Notice that the UI for the menu-bar ipfs menu locks up

The ipfs-desktop application will re-open in the dock with a pop-up confirmation indicating that you are on the latest version.

**Expected behavior**
Checking for updates is a non-blocking background operation.

**Screenshots**
Action:
image

Locked up UI:
image

Latest version confirmation popup:
image

**Additional context**
When I first ran into this bug, the Dock did not display the ifps-desktop icon. So I was unable to close the confirmation popup, and the UI stayed locked up, with the menu-bar menu remaining open and inaccessible.

[combined.log](https://github.com/ipfs/ipfs-desktop/files/8581500/combined.log)
[error.log](https://github.com/ipfs/ipfs-desktop/files/8581501/error.log)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.