ipfs / ipfs/ipfs-companion

Developer build does not work on MS Windows

Open
#796 0 comments 0 reactions 1 assignee Claimed by @lidel View on GitHub
kind/bug kind/maintenance
Dominant language
JavaScript
Stars
2.2k
Forks
338
Avg merge
3m
Merged PRs (30d)
1

Description

> extracted from #782

## Problem

Docker-based release builds runn in linux container, but regular `yarn dev-build` does not, and `$RELEASE_CHANNEL` variable is not set correctly on Windows.

## Fix

Just avoid shell scripting, move to JS. In this case:

- [ ] refactor `package.json`, simplify the way vendor-specific bundles are generated.
- [ ] Create JS script that reads ENV variable and takes care of both manifest update and merging
- [ ] Remove `ci/update-manifest.sh`
- [ ] Remove manifest merging in CLI
- [ ] Ensure manifest gets updated during `bundle:` tasks

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.