ipfs / ipfs/helia

bug: aborted signal not handled properly by libp2p router

Open
#780 5 comments 1 reaction 0 assignees View on GitHub
dif/expert effort/days kind/bug kind/discussion need/analysis P0
Dominant language
TypeScript
Stars
1.3k
Forks
159
Avg merge
2h 11m
Merged PRs (30d)
16

Description

See https://github.com/ipfs/service-worker-gateway/pull/681#issuecomment-2816001952.}

I don't have a good repro usecase besides some code changes in https://github.com/ipfs/service-worker-gateway/pull/681 and manual testing.

It's difficult to set up tests with all the things enabled that I need..

It's somewhere in the combination of `ipfs-unixfs-exporter` and `@helia/routers` when bitswap is enabled.

I was able to get this fixed in verified-fetch with:

```js
import { abortableSource } from 'abortable-iterator'

// ...

const iterator = options?.signal != null
? abortableSource(exporterWalk(path, blockstore, options), options.signal)
: exporterWalk(path, blockstore, options)
for await (const entry of iterator) {

// ...
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.