ipfs / ipfs/go-log

SetLogLevel defaultLevel not protected by mutex on wildcard case

Open
#189 0 comments 0 reactions 0 assignees View on GitHub
need/triage
Dominant language
Go
Stars
63
Forks
54
PR merge metrics
No merged PRs in 30d

Description

I opened this PR (https://github.com/ipfs/go-log/pull/188) with an extra mutex protection for defaultLevel on wildcard case.

Also added a concurrency test that fails with the previous version when running with -race flag.

This was observed after upgrading our dependencies.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing pull request #188, which contains the proposed mutex protection and concurrency test. Run the test with the race detector to reproduce the previous failure; done means the wildcard case is race-free and the concurrency test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.