ipfs / ipfs/go-ipld-format

Import DAG reader tests involving `NodePromise`s to actually test `NavigableIPLDNode`

Open
#50 1 comment 0 reactions 0 assignees View on GitHub
exp/novice help wanted
Dominant language
Go
Stars
65
Forks
27
PR merge metrics
No merged PRs in 30d

Description

The node prefetching mechanism has been abstracted away from the DAG reader in `go-unixfs` into the `NavigableIPLDNode` here, so the PR https://github.com/ipfs/go-unixfs/pull/12 which employs the `Walker` (that relies on `NavigableIPLDNode`) had to remove the related tests that acted directly on the internal `NodePromise` structure,

https://github.com/ipfs/go-unixfs/pull/12/files#diff-5a645da404e1845b770b90d1c81e71c6

Those tests should be recreated here (possibly without involving the DAG reader now, just testing the `FetchChild` and related methods of `NavigableIPLDNode` to actually create the `NodePromise`s following the spirit of the original test).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.