ipfs / ipfs/go-ipfs-cmds

Impossible to correctly handle timeouts.

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
52
Forks
45
PR merge metrics
No merged PRs in 30d

Description

It's currently impossible to correctly handle server-side context timeouts.

* Option 1: Call `SetError(ctx.Err())`. This will panic.
* Option 2: Simply return and close the channel. The outer handler may not have seen the context cancellation yet so it may decide to proceed and close the connection as if everything worked out as expected.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.