ipfs / ipfs/go-ipfs-cmds

Move CORS protection to go-ipfs/core/corehttp

Open
#27 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
52
Forks
45
PR merge metrics
No merged PRs in 30d

Description

```
keks | lgierth: currently the CORS protection is in go-ipfs-cmds/http and wraps the actual handler. Wouldn't it make much more sense to make it a ServerOption in go-ipfs/core/corehttp?
lgierth | yeah
keks | I'm already moving the version check (https://github.com/ipfs/go-ipfs-cmds/blob/master/http/handler.go#L326) there to get rid of ipfs dependencies
lgierth | go for it
keks | alright
lgierth | and don't bother too much with the gateway, it's gonna be gone to its own repo soon
keks | alright 👍
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.