ipfs / ipfs/go-ipfs-cmds

When emitting responses by value, the channel emitter should convert to a pointer

Open
#120 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
52
Forks
45
PR merge metrics
No merged PRs in 30d

Description

The http emitter does this automatically because we're serializing but the channel one doesn't. We could also assert the correct type but I'd actually just rather DWIM.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the channel emitter and compare its response handling with the HTTP emitter, which already converts values during serialization. Confirm how value responses are emitted and make the channel path convert them to pointers; done means channel-emitted responses behave consistently with HTTP responses.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.