ipfs / ipfs/go-graphsync

Implementing Data Deduplication Across Simultaneous Queries

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
exp/expert need/maintainer-input needs definition P3
Dominant language
Go
Stars
103
Forks
41
PR merge metrics
No merged PRs in 30d

Description

As described in ipld/specs#120 it would be great if we could hold off GCing the list of blocks we've sent to a peer until the end of multi-part request. This currently might happen by accident, since as long as one of the queries that accesses a duplicate node hasn't completed yet the reference won't be freed.

Each of the potential approaches mentioned in the issue above has its advantages and disadvantages. However, none of them seem like a particularly huge deal to implement since the protocol is already flexible enough to handle most of it.

@hannahhoward I'm happy to help with the implementation work here as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.