ipfs / ipfs/go-graphsync

Cleanup RequestManager.cancelRequestAndClose

Open
#222 0 comments 0 reactions 0 assignees View on GitHub
effort/hours exp/expert P2
Dominant language
Go
Stars
103
Forks
41
PR merge metrics
No merged PRs in 30d

Description

The use of cancelMessageChannel is quite confusing. The message send to the request manager internal channel can probably moved outside the loop to avoid confusion.

Contributor guide

Open the contributing guide

Research direction

Start by locating RequestManager.cancelRequestAndClose and inspect how cancelMessageChannel is used within its loop. Confirm the internal-channel message can be moved outside the loop without changing cancellation behavior, then run the relevant Go tests for the request manager; done means the cleanup is complete and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.