ipfs / ipfs/go-ds-flatfs

Doesn't work when with virtualbox shared volumes

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
52
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Basically, we try to sync a directory, windows fails with "invalid argument" ~(windows doesn't support syncing directories) and vbox forwards this error~.

~We actually have a check to avoid syncing directories on windows. Unfortunately... in this case, we think we're on Linux. I believe the correct fix is to detect that the error is an "invalid argument" error and ignore it (we can't sync anyways, nothing really failed).~

---

Edit: It turns out that vboxsf just doesn't support fsync on directories at all. Really, we probably should just be ignoring fsync errors on directories entirely (possibly logging them?). There's not much we can do anyways.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.