ipfs / ipfs/gateway-conformance

feat: add timeouts

Open
#89 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
19
Forks
15
Avg merge
1d 4h
Merged PRs (30d)
5

Description

We added a default timeout per test of 2 minutes to catch tests that would hang the CI
https://github.com/ipfs/gateway-conformance/pull/37#discussion_r1193580890

We're probably going to need "expected timeouts" for requests:
https://github.com/ipfs/gateway-conformance/pull/85#discussion_r1240456896

Creating this issue to capture discussions/notes.

Mains questions:

- [ ] I guess the behavior of a local Kubo daemon running in offline mode, and a fully deployed decentralized gateway will be very different, do we want to define timeouts at the test level ("that request should take less than 500ms") or at the gateway level ("that gateway should reply in less than 500ms")?
- [ ] Is it going to be driven by the specs?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.