ipfs / ipfs/gateway-conformance

Add QueryRaw

Open
#88 0 comments 0 reactions 0 assignees View on GitHub
feat:universality
Dominant language
Go
Stars
19
Forks
15
Avg merge
1d 4h
Merged PRs (30d)
5

Description

`Query` is percent-encoding values, `entity-bytes=2200:*` ends up as `2200%3A%2A`:

```
GET /ipfs/QmYhmPjhFjYFyaoiuNzYv8WGavpSRDwdHWe5B4M5du5Rtk?dag-scope=entity&entity-bytes=2200%3A%2A HTTP/1.1
```

while it should be:

```
GET /ipfs/QmYhmPjhFjYFyaoiuNzYv8WGavpSRDwdHWe5B4M5du5Rtk?dag-scope=entity&entity-bytes=2200:* HTTP/1.1
```

https://github.com/ipfs/gateway-conformance/actions/runs/5361027103/jobs/9726581993?pr=85#step:10:4615

@laurentsenta escaping is fine most of the time, but for this specific case, maybe we could add `QueryRaw` for cases like this one? I suspect this happens to work only because `boxo/gateway` does percent-decoding by default too, but other implementations may not do this extra step for this parameter.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.