ipfs / ipfs/gateway-conformance

Relax tests related to only-if-cached

Open
#142 0 comments 0 reactions 0 assignees View on GitHub
test:coverage
Dominant language
Go
Stars
19
Forks
15
Avg merge
1d 4h
Merged PRs (30d)
5

Description

Not every implementation will keep blocks around in a local cache.

For example, bifrost-gateway with CAR backend may not keep blocks around for this to ever pass (we had to disable `only-if-cached` tests in https://github.com/ipfs/bifrost-gateway/pull/190).

```[tasklist]
### Tasks
- [ ] restore tests of `only-if-cached` back to Kubo ([we removed them here](https://github.com/ipfs/kubo/pull/9999/files#diff-fb62f7f90421833b83d97fa334f956984842f4ea9ba68d5f2a8433b8bfc638e4L119)). we want to make sure `only-if-cached` is implemented there.
- [ ] relax gateway-conformance tests so they pass when response is EITHER 200 or 412 Precondition Failed
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.