ipfs / ipfs/distributions

Windows signing

Open
#384 1 comment 0 reactions 0 assignees View on GitHub
dif/expert effort/days kind/maintenance P3 status/ready
Dominant language
Less
Stars
50
Forks
30
Avg merge
50m
Merged PRs (30d)
1

Description

## Problem

Lack of signing on Windows means that when a binary is run for the first time and tries to access networking it gets Windows Defender Firewall warning with "Publisher: Unknown":

> ![image](https://user-images.githubusercontent.com/157609/128746455-129809e9-dd71-46be-ad97-84fce37e3416.png)
> Screenshot from dev instance in Brave (without signing done by Brave, to illustrate the problem)

My guess is that over time, MS Windows will get more and more strict, just like macOS did in recent years.

## Solution: sign windows binaries

* ipfs-desktop has some signing keys set up, but I am not sure how reusable those are (TBD if we need to generate unique pair for each package, or can sign everything with the same pair)
* We moved build to CI and introduced macOS signing in #367, which makes things easier:
* Adding `sign-windows` job after `sign-macos` (sequentially) should be easy and fast enough
(we can parallelize them if needed, but given how long macos signing takes, the difference will be minimal)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.