ipfs / ipfs/boxo

[ipfs/go-bitswap] Wantlist Race B

Open
#96 0 comments 0 reactions 0 assignees View on GitHub
kind/bug
Dominant language
Go
Stars
316
Forks
163
Avg merge
4d 12h
Merged PRs (30d)
8

Description

Forked from: https://github.com/ipfs/go-bitswap/issues/99

**Problem**

1. Peer A connects to peer B.
2. Peer A sends its wantlist to peer B.
3. Peer A disconnects from peer B.
4. Peer B notices the disconnect, forgets peer A's wantlist.
5. Peer A immediately reconnects to peer B.
6. Peer A notices the disconnect, sees that it still _has_ a connection, doesn't resend it's wantlist.

**Solution**

The only thing I can think of is the following: whenever the stream we're using to send wantlists closes, we (a) open a new one and (b) send the _complete_ wantlist. Unfortunately, I _really_ wanted to eventually move away from keeping a stream open entirely but, we'll, I can't think of a better solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.