files(ShouldExclude): compatibility with gitignore
Open
dif/medium
effort/days
help wanted
kind/bug
P3
- Dominant language
- Go
- Stars
- 316
- Forks
- 163
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 8
Description
Bug extracted from https://github.com/ipfs/boxo/pull/516, my rough understanding is:
- The current implementation `ShouldExclude` is not fully compatible with https://git-scm.com/docs/gitignore.
- > [There is an] issue where bar/ didn't catch directories. [Both] bar and bar/ rules [should] filter out the bar directory and its contents.
- To be fully compatible, the paths have to be matched against a relative path, right now it's just a [file name](https://github.com/ipfs/boxo/blob/fe0a8237ce7ca56e314928152a18886c0b147fce/files/filter.go#L45).
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.