ipfs / ipfs/boxo

bitswap: `BitSwapNetwork` notifies about connected peers that do not speak Bitswap

Open
#631 4 comments 0 reactions 0 assignees View on GitHub
dif/medium effort/days kind/enhancement P2 topic/bitswap
Dominant language
Go
Stars
316
Forks
163
Avg merge
4d 12h
Merged PRs (30d)
8

Description

[Here](https://github.com/ipfs/boxo/blob/dfd4a53ba828a368cec8d61c3fe12969ac6aa94c/bitswap/network/ipfs_impl.go#L459) we listen and pass newly connected peers to Bitswap Client and Server. However, we do that for all our peers, including those who do not speak Bitswap protocol.

This is not a big problem because we will quickly realize that such peers are unresponsive, but we could still filter them out much earlier. This potentially warrants migrating to Identify libp2p events that now contain the list of protocols the peer supports.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.