ipfs / ipfs/aegir

bug: `aegir test --bail` doesn't adhere to build configuration

Open
#1,488 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
105
Forks
62
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

Running tests with `npx aegir test --bail false` flag will not trigger `aegir build` which would be otherwise triggered by `npx aegir test`

**To Reproduce**
Steps to reproduce the behavior:
1. Go to any project configured with aegir build and test, such as https://github.com/ipfs/helia-verified-fetch
2. run `npm run clean` to ensure `dist` folder is removed
3. run `npm run test` and see that tests run successfully after building
4. run `npm run clean` to ensure that `dist` folder is removed
5. run `npm run test -- --bail false` and see the below error message: `Error: No test files found`

image

**Expected behavior**
I expect the same test flow to occur, though mocha should no longer bail for any given test.

**Additional context**

I have been running some tests with `DEBUG="test*,test*:trace" npm run test -- -g 'abort-handling'`
and then running `DEBUG="test*,test*:trace" npm run test -- -g 'abort-handling' --bail false` while changing some things. When running tests without the bail flag, aegir builds my tests and then runs the tests as expected. With it, aegir does not rebuild the src & tests.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.