ipfs / ipfs/aegir

Coverage in aegir + node hangs on CI and Local Dev

Open
#1,206 4 comments 0 reactions 1 assignee Claimed by @laurentsenta View on GitHub
team/ipdx
Dominant language
JavaScript
Stars
105
Forks
62
PR merge metrics
No merged PRs in 30d

Description

## Describe the bug
We had to disable code coverage in node 18, which pushed the burden of checking code coverage onto maintainers and PR reviewers.

@achingbrain has prepared a PR to enable it back, but it's still blocking:
https://github.com/ipfs/aegir/pull/1195

Examples:
https://github.com/ipfs/aegir/actions/runs/4225847659/jobs/7338650113

@BigLep shared details on why we need to solve this in https://filecoinproject.slack.com/archives/C03KLC57LKB/p1678122004165499

Options:
- Figure out what happens and fix it,
- Use a different code coverage tool that doesn't have the same issue.
- NYC might be abandoned: https://github.com/istanbuljs/nyc/issues/1514

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.