ipfs / ipfs/aegir

bug [test] target: environment should ignore other environment specific tests

Open
#1,097 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
105
Forks
62
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
The test runner produces the following pattern for testing:

```sh
[
'test/.{js,cjs,mjs}',
'test/**/*.spec.{js,cjs,mjs}',
'dist/test/.{js,cjs,mjs}',
'dist/test/**/*.spec.{js,cjs,mjs}',
]
```

but `*.spec.{js,cjs,mjs}` already includes everything, so if the environment is `node` it would also end up running test for `browser` it should ignore `browser`

**To Reproduce**
in the `tests` folder, create test:
- `node.spec.js`
- `browser.spec.js`
- `test.spec.js`

Run tests: `aegir test --target node`.

**Expected behavior**

Only the following tests should Run:
- `node.spec.js`
- `test.spec.js`

Instead all three run.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.