ipfs-shipyard / ipfs-shipyard/pm-idm
Improve IdlePicker's implementation
- Dominant language
- No language data
- Stars
- 64
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
## Description
The current implementation of IdlePicker, though it works as intended, is sub-optimal. As of now, it calls the `render` method five times, in some cases, when picking a new value. This happens as a workaround to some issues that occurred while extending the `rc-slider` external component with handle and track animations.
The logic of the component should be changed so that the superfluous renders of different values when picking a new value no longer occurs.
## Acceptance Criteria
- [ ] IdlePicker retains its current correct behavior.
- [ ] Superfluous renders when picking a value are avoided.
- [ ] Allow the value to be completely controlled, instead of having a default value
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the IdlePicker component and its integration with the rc-slider handle and track animations. Trace the render calls when selecting a value, then verify that current behavior is preserved, superfluous renders are removed, and the value can be fully controlled instead of using a default.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100