iovisor / iovisor/bcc

Move BPF instruction helper macros to uapi header?

Open
#758 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
22.7k
Forks
4.1k
Avg merge
10d 4h
Merged PRs (30d)
3

Description

The BPF instruction helper macros (`BPF_ALU64_REG`, `BPF_EXIT_INSN`, and the like) are duplicated in a few places in the kernel tree: [include/linux/filter.h](http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/filter.h?h=v4.9-rc1), [tools/include/linux/filter.h](http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/include/linux/filter.h?h=v4.9-rc1), and [samples/bpf/libbpf.h](http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/samples/bpf/libbpf.h?h=v4.9-rc1). bcc also has its own redefinitions. This seems kind of silly. Would it make sense to move these definitions into a common uapi header?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.