iovisor / iovisor/bcc

bps tool is installed to wrong location

Open
#4,925 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C
Stars
22.7k
Forks
4.1k
Avg merge
5d 13h
Merged PRs (30d)
3

Description

Hi! :wave:

I'm currently cleaning up and rebuilding the bcc package for Arch Linux.

I noticed that the bps tool is installed by default
https://github.com/iovisor/bcc/blob/6cd272189771bbc7120d9d834e2588b93d8e9cfa/introspection/CMakeLists.txt#L12

but to the wrong/ hardcoded location:

https://github.com/iovisor/bcc/blob/6cd272189771bbc7120d9d834e2588b93d8e9cfa/introspection/CMakeLists.txt#L29

According to [FHS](https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard) the `/usr/share/` location is for
> Architecture-independent (shared) data.

As bps is a binary, it is architecture-dependent and should be installed to `/usr/bin/` instead as it is for
> Non-essential command [binaries](https://en.wikipedia.org/wiki/Executable) (not needed in [single-user mode](https://en.wikipedia.org/wiki/Single-user_mode)); for all users.

Is there a particular reason why the bps executable is installed to this location?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with introspection/CMakeLists.txt, especially the referenced lines that install bps. Check the intended installation conventions for this command-line binary and how the generated package places it. Done means the install destination is no longer hardcoded to the inappropriate location and the resulting package layout is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cmake
Domain
build-system, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.