iovisor / iovisor/bcc

.clang_format is at the top of repository, but it seems the code was not formatted by clang-format

Open
#3,746 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
22.7k
Forks
4.1k
Avg merge
10d 4h
Merged PRs (30d)
3

Description

I am running clang-format on src/cc/bcc_exception.h:
```
$ clang-format -i src/cc/bcc_exception.h
```
The entire file pretty much was all edited.

So if I update .clang-format to match the existing style (for example, pointer affix to variable instead of type char *ptr vs. char* ptr), would it make sense to ask contributter to run clang-format before sending PR, and add clang-format checker somewhere in the PR process?

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the existing style in src/cc/bcc_exception.h with the repository's .clang-format configuration, starting with the pointer-affix example in the issue. Review the current pull-request process to determine where formatting validation could run. Done means the agreed style is represented by the configuration and formatting is checked during pull requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.