iotile / iotile/coretools

`ota_updater` os_version checks needs major-minor-patch

Open
#597 0 comments 0 reactions 1 assignee Claimed by @mattrunchey View on GitHub
type:bug
Dominant language
Python
Stars
14
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Right now the cloud only sends over major.minor for most things, but could possibly send all 3. However, when converting with `SemanticVersion.FromString`, that method requires the patch or it errors out.

One of two things needs to change:
1) `semver` should imply a 0 for patch if not provided
2) `ota_updater` should imply a 0 for patch if not provided, so that calling `FromString` works.

@timburke is there anything preventing us from altering the semver behavior, or do you have an opinion on what to change? Technically we could also update the Cloud's expectation for os_version and app_version to require the full major.minor.patch. Right now I don't believe the cloud has any enforcement mechanism for sanitizing the update requirements, but that's just what I derived from the project docs.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.