iotile / iotile/coretools

See if `VirtualAdapter` really needs to periodically send scan_events

Open
#583 0 comments 0 reactions 0 assignees View on GitHub
iotile-core iotile-gateway type:technical-debt
Dominant language
Python
Stars
14
Forks
7
PR merge metrics
No merged PRs in 30d

Description

VirtualAdapter, when first written, sent periodic scan events for all virtual devices attached to it. This was important because CoreTools didn't yet support `probing` for devices and required that DeviceAdapter subclasses push events for each device seen.

We have since impemented probing and VirtualAdapter uses probing now but it still sends gratuitous scan events in its periodic adapter callback. We should verify if this is actually still necesary or just leftover from an incomplete refactor.

The place where it could still be necessary is if IOTileGateway does not support probing yet so this behavior is necessary for VirtualAdapters to work when connected to an IOTileGateway.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.