Update for compatibility with pyparsing 2.3.0
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 14
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
It looks like pyparsing 2.3.0 is backwards incompatible even though it's marked as a minor update. It came out 12 hours ago and it looks like it breaks iotile-sensorgraph and possibly also iotile-build.
Immediate fix is to pin the version specifier of pyparsing in both packages to pyparsing~=2.2.0 but we should fix but we should also fix the incompatibility and move to using pyparsing 2.3.0.
It looks from the release notes like they fixed a previous bug that we had already built a workaround to inside out code and the fix changes the behavior in a way that breaks the workaround.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the pyparsing dependency declarations in iotile-sensorgraph and iotile-build, then trace the existing workaround affected by the 2.3.0 behavior change. Compare both packages with pyparsing 2.3.0 and confirm the compatibility issue is resolved; otherwise retain the stated version pin as the fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100