iotaledger / iotaledger/product-core

[Request]: Check if TransactionSigner::iotaPublicKeyBytes() is still needed

Open
#36 0 comments 0 reactions 1 assignee Claimed by @UMR1352 View on GitHub
Dominant language
Rust
Stars
0
Forks
2
Avg merge
1h 29m
Merged PRs (30d)
3

Description

### Feature description

In the past we were facing problems with converting a public key from TS to Rust and vice-versa.

For this reason the [TransactionSigner](https://github.com/iotaledger/product-core/blob/main/bindings/wasm/iota_interaction_ts/src/bindings/wasm_transaction_signer.rs) interface offers two functions, `iotaPublicKeyBytes: () => Promise` and `publicKey: () => Promise` to access the public key.

We might have fixed the issue that made unreliable the conversion of a public key from TS to Rust and vice-versa.

This should be checked. If conversion is no more unreliable we should remove the function `iotaPublicKeyBytes()` from the `TransactionSigner` interface.

### Motivation

Avoid unneeded code

### Requirements

-

### Open questions

_No response_

### Are you planning to do it yourself in a pull request?

Yes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.