iotaledger / iotaledger/firefly

[Task]: Investigate why some transactions show as burned for restored account

Open
#7,617 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
478
Forks
100
PR merge metrics
No merged PRs in 30d

Description

### Task description

Sometimes Activities show as Burned on restored account because transaction, that was created on original account, gets returned as part of the results set of the `account.incomingTransactions()` SDK call while on the original account it gets returned in the `account.transactions()`. So the consequence is that transaction is "missing" on the restored account.
Since transaction is "missing" FF than tries to create Activity, for restored account, from processing outputs associated to the account. The issue is that the `account.output()` doesn't return all outputs for the "missing" transaction but rather only the "remainder" output.
As a result the Activity gets recreated form partial set of outputs and is shown as Burned.

related to https://github.com/iotaledger/firefly/pull/7584#pullrequestreview-1681787736
related to https://github.com/iotaledger/iota-sdk/issues/1502

### Requirements

Correctly create Activity for restored account

### Creation checklist

- [ ] I have assigned this task to the correct people
- [ ] I have added the most appropriate labels
- [X] I have linked the correct milestone and/or project

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.